Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gnoclient): modify Run to use baseTxCfg & multiple MsgRun args #1637

Merged
merged 13 commits into from
Feb 23, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Feb 7, 2024

Description

This PR makes the Gnoclient Run method implement multiple MsgRun args, and use the preexisting baseTxCfg struct. It also introduces unit & integration tests (basis for which was @jefft0's code in a previous PR), optimizes Call & Run code as per comment, and fixes a bug in code and in previous tests found along the way.

Another, separate PR will be made to add even more tests for gnoclient.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@leohhhn leohhhn requested a review from jefft0 February 7, 2024 21:40
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (59d8787) 56.57% compared to head (9f020a8) 56.24%.

Files Patch % Lines
gno.land/pkg/gnoclient/client_txs.go 84.31% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1637      +/-   ##
==========================================
- Coverage   56.57%   56.24%   -0.33%     
==========================================
  Files         439      439              
  Lines       66618    66242     -376     
==========================================
- Hits        37688    37258     -430     
- Misses      26013    26095      +82     
+ Partials     2917     2889      -28     
Flag Coverage Δ
go-1.21.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jefft0
Copy link
Contributor

jefft0 commented Feb 8, 2024

I see that you added me as a reviewer. To review, I'll wait until CI errors are fixed and the PR is not Draft. 😁

@leohhhn leohhhn marked this pull request as ready for review February 8, 2024 15:25
@leohhhn leohhhn requested a review from moul as a code owner February 8, 2024 15:25
gno.land/pkg/gnoclient/util.go Outdated Show resolved Hide resolved
gno.land/pkg/gnoclient/util.go Show resolved Hide resolved
gno.land/pkg/gnoclient/client_txs.go Show resolved Hide resolved
gno.land/pkg/gnoclient/client_txs.go Outdated Show resolved Hide resolved
gno.land/pkg/gnoclient/client_txs.go Show resolved Hide resolved
gno.land/pkg/gnoclient/client_txs.go Show resolved Hide resolved
gno.land/pkg/gnoclient/client_test.go Outdated Show resolved Hide resolved
@leohhhn leohhhn requested review from a team, jaekwon, piux2 and harry-hov as code owners February 8, 2024 18:09
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Feb 8, 2024
@leohhhn leohhhn removed request for a team, jaekwon, moul, harry-hov and piux2 February 8, 2024 18:10
@github-actions github-actions bot removed the 📦 🤖 gnovm Issues or PRs gnovm related label Feb 8, 2024
@leohhhn leohhhn mentioned this pull request Feb 9, 2024
7 tasks
Copy link
Contributor

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go test . works for me. I'm able to compile a test program and use Run.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; ping @zivkovicmilos / @gfanton for second review/merge

@thehowl thehowl requested a review from gfanton February 22, 2024 20:52
Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@gfanton gfanton merged commit 0c3d4ae into gnolang:master Feb 23, 2024
178 of 180 checks passed
@leohhhn leohhhn deleted the chore/basetx-msgrun branch February 23, 2024 11:00
leohhhn added a commit to leohhhn/gno that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants