Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Move Effective Gno, reorg Concepts ordering #1652

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Feb 12, 2024

Description

This PR moves the Effective Gno page from How-to's, to Concepts, and also reorders the Concepts section in the sidebar.

To follow the Diataxis framework more closely, Effective Gno should be in the Concepts (Explanation) section.

Also, I removed the quotation marks from the ID to match the rest of docs content.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@leohhhn leohhhn marked this pull request as ready for review February 12, 2024 10:21
@leohhhn leohhhn requested review from a team as code owners February 12, 2024 10:21
@leohhhn leohhhn merged commit a2b5f29 into gnolang:master Feb 12, 2024
9 checks passed
@leohhhn leohhhn deleted the docs/eff-gno branch February 12, 2024 18:35
leohhhn added a commit to leohhhn/gno that referenced this pull request Feb 29, 2024
## Description

This PR moves the `Effective Gno` page from How-to's, to Concepts, and
also reorders the Concepts section in the sidebar.

To follow the Diataxis framework more closely, `Effective Gno` should be
in the Concepts ([Explanation](https://diataxis.fr/explanation/))
section.

Also, I removed the quotation marks from the ID to match the rest of
docs content.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants