feat(gnodev): add node tests and lint #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfanton
force-pushed
the
fix/gnodev-test
branch
from
fb20913
to
56df99c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1668 +/- ##
==========================================
+ Coverage 46.63% 48.36% +1.73%
==========================================
Files 492 409 -83
Lines 69624 62035 -7589
==========================================
- Hits 32472 30006 -2466
+ Misses 34445 29531 -4914
+ Partials 2707 2498 -209 ☔ View full report in Codecov by Sentry. |
gfanton
force-pushed
the
fix/gnodev-test
branch
from
7547c08
to
d0e482b
Compare
gfanton
force-pushed
the
fix/gnodev-test
branch
from
6ee0a30
to
e632eba
Compare
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
…thread safe Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
gfanton
force-pushed
the
fix/gnodev-test
branch
from
f44603d
to
10c7c2d
Compare
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
gfanton
force-pushed
the
fix/gnodev-test
branch
from
78618d4
to
b92c7e5
Compare
gfanton
changed the title
gfanton
force-pushed
the
fix/gnodev-test
branch
from
7880ef7
to
decc397
Compare
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
gfanton
force-pushed
the
fix/gnodev-test
branch
from
decc397
to
49021ed
Compare
moul
reviewed
Apr 22, 2024
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
zivkovicmilos
approved these changes
Apr 25, 2024
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
gfanton
force-pushed
the
fix/gnodev-test
branch
from
e77e309
to
1667570
Compare
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some basic tests to
nodeandemitterpackages fromgnodevto prevent regression.I also made the node thread-safe during the process as it was necessary to test the node.
Edit: Added linting, as
golangci-lintwas ignoringgnodevdirectory.Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description