Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website: Add syntax highlighting + security practices #167

Merged
merged 12 commits into from
May 5, 2022
Merged

Website: Add syntax highlighting + security practices #167

merged 12 commits into from
May 5, 2022

Conversation

loicttn
Copy link
Contributor

@loicttn loicttn commented May 5, 2022

Hey gnoland 👋

In this PR you will find:

  • syntax highlighting for gno files rendered in the website (using highlightjs)
  • usage of DOMPurify to sanitize all rendered markdown
  • a first draft of a Security documentation, explaining the best practices for the current minimal website

@loicttn loicttn changed the title Website: Add syntax + security practices Website: Add syntax highlighting + security practices May 5, 2022
@moul
Copy link
Member

moul commented May 5, 2022

Just sharing some screenshots for the curious ones :
Screenshot 2022-05-05 at 15 19 42@2x
)

moul
moul approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@moul
Copy link
Member

moul commented May 5, 2022

bonus ideas for later:

  • dynamically replace @blahblah with a link like that [@blahblah](r/users:blahblah)
  • make the import urls clickable in source mode

@jaekwon jaekwon merged commit 797c7a1 into gnolang:master May 5, 2022
@moul moul added this to the 🏗1️⃣ test1.gno.land milestone Oct 20, 2022
moul added a commit to gnolang/game-of-realms that referenced this pull request Oct 14, 2023
@moul
add notable contribution for @loicttn
f7bc396 
- endorsed: @loicttn 
- contribution: gnolang/gno#167
- originally endorsed by @jaekwon in gnolang/gno@474a048
@moul moul mentioned this pull request Oct 14, 2023
Merged
moul added a commit to gnolang/game-of-realms that referenced this pull request Oct 18, 2023
@moul
add notable contribution for @loicttn (#7)
3c6ab8a 
- endorsed: @loicttn 
- contribution: gnolang/gno#167
- originally endorsed by @jaekwon in gnolang/gno@474a048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moul moul moul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
🚀 The Launch [DEPRECATED]
Archived in project
Milestone
🏗1️⃣ test1.gno.land
Development

Successfully merging this pull request may close these issues.
3 participants
@loicttn @moul @jaekwon