Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add network configuration table #1707

Merged
merged 2 commits into from
Feb 29, 2024
Merged

feat: add network configuration table #1707

merged 2 commits into from
Feb 29, 2024

Conversation

waymobetta
Copy link
Contributor

@waymobetta waymobetta commented Feb 29, 2024

This PR introduces network configurations to the RPC endpoints page within our documentation.

Closes: #1706

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@waymobetta waymobetta requested a review from a team as a code owner February 29, 2024 07:04
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a couple of small comments.

docs/reference/rpc-endpoints.md Outdated Show resolved Hide resolved
docs/reference/rpc-endpoints.md Outdated Show resolved Hide resolved
@waymobetta waymobetta merged commit 75539ea into gnolang:master Feb 29, 2024
6 checks passed
@waymobetta waymobetta deleted the feat/docs-network-configs branch February 29, 2024 14:25
leohhhn pushed a commit to leohhhn/gno that referenced this pull request Feb 29, 2024
<!-- please provide a detailed description of the changes made in this
pull request. -->
This PR introduces network configurations to the RPC endpoints page
within our
[documentation](https://docs.gno.land/reference/rpc-endpoints).

Closes: gnolang#1706 

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

Add network configurations table to docs
2 participants