Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update getting-started with gno test #1712

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

MalekLahbib
Copy link
Contributor

@MalekLahbib MalekLahbib commented Mar 1, 2024

gno test -verbose -root-dir /Users/zmilos/Work/gno . --> will not work, It needs to be changed to gno test -verbose . so that it works for anyone.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@MalekLahbib MalekLahbib requested a review from a team as a code owner March 1, 2024 11:24
@moul moul changed the title Update testing-gno.md docs: update getting-started with gno test Mar 1, 2024
@moul
Copy link
Member

moul commented Mar 1, 2024

Hey @gnolang/devrels, I suggest adding a straightforward command for beginners that eliminates the need for the -root-dir argument, which can be confusing and is not commonly used. Additionally, consider including an advanced section that addresses common errors, such as "import not found," prompting users to specify a root directory.

Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for noticing this and correcting it! This was an error that no one saw beforehand :)

@thehowl
Copy link
Member

thehowl commented Mar 1, 2024

@moul: I suggest adding a straightforward command for beginners that eliminates the need for the -root-dir argument, which can be confusing and is not commonly used

#1248 :)

@thehowl thehowl merged commit eb44d42 into gnolang:master Mar 1, 2024
9 of 10 checks passed
@MalekLahbib MalekLahbib deleted the patch-1 branch March 2, 2024 10:24
leohhhn pushed a commit to leohhhn/gno that referenced this pull request Mar 6, 2024
`gno test -verbose -root-dir /Users/zmilos/Work/gno .` --> will not
work, It needs to be changed to `gno test -verbose .` so that it works
for anyone.

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants