Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add new Prerequisites #1722

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Conversation

DIGIX666
Copy link
Contributor

@DIGIX666 DIGIX666 commented Mar 2, 2024

I propose this change in the prerequisites of the getting-started because @kazai777 and I (mac apple silicon users) encountered a command not found with the given commands. And by checking with echo $GOPATH, the path was empty. We noticed that in the newer versions of Go, one must manually add the path.

However, thanks to @mous1985 , we saw that on Ubuntu, it was set automatically.

Warning -> this also needs to be verified on Windows.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@DIGIX666 DIGIX666 requested a review from a team as a code owner March 2, 2024 19:30
@DIGIX666 DIGIX666 changed the title Add new Prerequisites Docs: add new Prerequisites Mar 3, 2024
@DIGIX666 DIGIX666 changed the title Docs: add new Prerequisites docs: add new Prerequisites Mar 3, 2024
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition! I've left a comment and a suggestion below. Thanks 🙏

docs/getting-started/local-setup.md Outdated Show resolved Hide resolved
Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
@leohhhn leohhhn merged commit 9199eee into gnolang:master Mar 4, 2024
6 checks passed
leohhhn added a commit to leohhhn/gno that referenced this pull request Mar 6, 2024
<!-- please provide a detailed description of the changes made in this
pull request. -->
I propose this change in the prerequisites of the
[getting-started](https://docs.gno.land/getting-started/local-setup)
because @kazai777 and I (mac apple silicon users) encountered a `command
not found` with the given commands. And by checking with `echo $GOPATH`,
the path was empty. We noticed that in the newer versions of Go, one
must manually add the path.

However, thanks to @mous1985 , we saw that on Ubuntu, it was set
automatically.

Warning -> this also needs to be verified on Windows.
<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Co-authored-by: théo dub <theodub@MacThox.local>
Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants