Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gno.land): update content on pages #1735

Merged
merged 28 commits into from
Mar 6, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Mar 5, 2024

Description

This PR updates the content on the home page of gno.land, as well as content in some other pages that are linked on the home page. This change was requested by @ccomben.

The PR includes:

  • Updating welcome text (intro section) on homepage
  • Updating text on the "About" page
  • Updating the events page - moving old to the past past events section, adding the details of GopherCon EU
  • Updating the Ecosystem page
  • Reordering sections on the home page
  • Updating broken and missing links
  • Making the home page more intuitive to navigate

Pages have their H1 removed from the body because the package that renders it (p/demo/blog) will render it twice with the current version of the package.

This one in a series of PRs looking to improve the experience of people visiting gno.land.

Please, let's not bikeshed on this one - otherwise we will get nowhere. The Portal loop is live now, which means that a change or a fix on any of the pages is only 1 PR away if it's needed. Also, all changes in this PR are minor.

To review this PR, I highly suggest running gnodev and looking at the changes rendered and comparing them to the current gno.land pages.

Seems running make test.sync doesn't properly update golden tests - an issue for itself.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@leohhhn leohhhn changed the title chore(gno.land): update intro section on home page chore(gno.land): update home page content Mar 5, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.43%. Comparing base (f976e25) to head (8fa6213).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1735   +/-   ##
=======================================
  Coverage   47.43%   47.43%           
=======================================
  Files         384      384           
  Lines       61201    61201           
=======================================
  Hits        29028    29028           
  Misses      29744    29744           
  Partials     2429     2429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leohhhn leohhhn changed the title chore(gno.land): update home page content chore(gno.land): update content on pages Mar 5, 2024
@leohhhn leohhhn marked this pull request as ready for review March 5, 2024 22:52
@leohhhn leohhhn requested a review from moul as a code owner March 5, 2024 22:52
@zivkovicmilos zivkovicmilos self-requested a review March 6, 2024 11:20
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

examples/gno.land/r/gnoland/home/home.gno Outdated Show resolved Hide resolved
examples/gno.land/r/gnoland/pages/page_about.gno Outdated Show resolved Hide resolved
examples/gno.land/r/gnoland/pages/page_gnolang.gno Outdated Show resolved Hide resolved
@leohhhn leohhhn merged commit ce47828 into gnolang:master Mar 6, 2024
185 of 187 checks passed
@leohhhn leohhhn deleted the chore/update-home branch March 6, 2024 12:40
leohhhn added a commit to leohhhn/gno that referenced this pull request Mar 6, 2024
## Description

This PR updates the content on the home page of gno.land, as well as
content in some other pages that are linked on the home page. This
change was requested by @ccomben.

The PR includes:
- Updating welcome text (intro section) on homepage
- Updating text on the "About" page
- Updating the events page - moving old to the past past events section,
adding the details of GopherCon EU
- Updating the Ecosystem page
- Reordering sections on the home page
- Updating broken and missing links
- Making the home page more intuitive to navigate

Pages have their H1 removed from the `body` because the package that
renders it (p/demo/blog) will render it twice with the current version
of the package.

This one in a series of PRs looking to improve the experience of people
visiting gno.land.

**Please, let's not bikeshed on this one** - otherwise we will get
nowhere. The Portal loop is live now, which means that a change or a fix
on any of the pages is only 1 PR away if it's needed. **Also, all
changes in this PR are minor.**

To review this PR, I highly suggest running `gnodev` and looking at the
changes rendered and comparing them to the current `gno.land` pages.

Seems running make test.sync doesn't properly update golden tests - an
issue for itself.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Co-authored-by: Morgan <git@howl.moe>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants