-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gno.land): update content on pages #1735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leohhhn
changed the title
chore(gno.land): update intro section on home page
chore(gno.land): update home page content
Mar 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1735 +/- ##
=======================================
Coverage 47.43% 47.43%
=======================================
Files 384 384
Lines 61201 61201
=======================================
Hits 29028 29028
Misses 29744 29744
Partials 2429 2429 ☔ View full report in Codecov by Sentry. |
leohhhn
changed the title
chore(gno.land): update home page content
chore(gno.land): update content on pages
Mar 5, 2024
zivkovicmilos
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
thehowl
approved these changes
Mar 6, 2024
Co-authored-by: Morgan <git@howl.moe>
Co-authored-by: Morgan <git@howl.moe>
leohhhn
added a commit
to leohhhn/gno
that referenced
this pull request
Mar 6, 2024
## Description This PR updates the content on the home page of gno.land, as well as content in some other pages that are linked on the home page. This change was requested by @ccomben. The PR includes: - Updating welcome text (intro section) on homepage - Updating text on the "About" page - Updating the events page - moving old to the past past events section, adding the details of GopherCon EU - Updating the Ecosystem page - Reordering sections on the home page - Updating broken and missing links - Making the home page more intuitive to navigate Pages have their H1 removed from the `body` because the package that renders it (p/demo/blog) will render it twice with the current version of the package. This one in a series of PRs looking to improve the experience of people visiting gno.land. **Please, let's not bikeshed on this one** - otherwise we will get nowhere. The Portal loop is live now, which means that a change or a fix on any of the pages is only 1 PR away if it's needed. **Also, all changes in this PR are minor.** To review this PR, I highly suggest running `gnodev` and looking at the changes rendered and comparing them to the current `gno.land` pages. Seems running make test.sync doesn't properly update golden tests - an issue for itself. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Morgan <git@howl.moe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the content on the home page of gno.land, as well as content in some other pages that are linked on the home page. This change was requested by @ccomben.
The PR includes:
Pages have their H1 removed from the
body
because the package that renders it (p/demo/blog) will render it twice with the current version of the package.This one in a series of PRs looking to improve the experience of people visiting gno.land.
Please, let's not bikeshed on this one - otherwise we will get nowhere. The Portal loop is live now, which means that a change or a fix on any of the pages is only 1 PR away if it's needed. Also, all changes in this PR are minor.
To review this PR, I highly suggest running
gnodev
and looking at the changes rendered and comparing them to the currentgno.land
pages.Seems running make test.sync doesn't properly update golden tests - an issue for itself.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description