Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tm2): remove pkg/maths in favour of min/max #1746

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Mar 8, 2024

I was taking a look at what packages we have in tm2/pkg and realised we had an entire package to do what are, since go 1.21, builtin functions.

This PR removes tm2/pkg/maths in favour of the now standard and generic go implementation of the same functionality.

@thehowl thehowl self-assigned this Mar 8, 2024
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 44.70%. Comparing base (45c8f90) to head (a53b767).

Files Patch % Lines
tm2/pkg/p2p/conn/connection.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1746      +/-   ##
==========================================
- Coverage   47.41%   44.70%   -2.72%     
==========================================
  Files         384      455      +71     
  Lines       61187    67492    +6305     
==========================================
+ Hits        29014    30169    +1155     
- Misses      29744    34797    +5053     
- Partials     2429     2526      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thehowl thehowl merged commit 40c6362 into master Mar 13, 2024
184 checks passed
@thehowl thehowl deleted the dev/morgan/remove-pkg-maths branch March 13, 2024 14:34
albttx pushed a commit to albttx/gno that referenced this pull request Mar 15, 2024
I was taking a look at what packages we have in tm2/pkg and realised we
had an entire package to do what are, since go 1.21, builtin functions.

This PR removes tm2/pkg/maths in favour of the now standard and generic
go implementation of the same functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants