-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stdlib): add unicode/utf16
pacakge
#1764
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1764 +/- ##
==========================================
- Coverage 44.79% 44.79% -0.01%
==========================================
Files 459 459
Lines 67642 67642
==========================================
- Hits 30300 30297 -3
- Misses 34808 34809 +1
- Partials 2534 2536 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I'd strongly recommend removing the export_test.gno
file and changing the package to utf16_test
in utf16_test.gno
. This is for a couple of reasons:
- It makes the test file's "unicode/utf16" import meaningful
- It separates testing code from the package code, ensuring that we are testing the same API users are interacting with.
This will require the package prefix to be added to the tests, but that's fine. The only reason the go stdlib tests for this package don't have that is because they use the dot import, something gno does not support.
I thought it was customary to include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
Description
unicode/utf16
package. transffered directly from Go without any changes.stdlibWhitelist
transpiler.goIn an earlier JSON PR #1415 , I included this
unicode/utf16
to handle unescaping and other byte slice operations, but realized that I wasn't using it in that package, leading me to submit a separate PR sepcifically for this.