chore(CODEOWNERS): update rules #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current state: want to finish up adding more rules for the /examples/ directory, and revisit with a fresh mind the new rules added. Good to receive input on the current proposed rulechanges, though. |
moul
reviewed
Mar 26, 2024
moul
reviewed
Mar 26, 2024
moul
approved these changes
Mar 26, 2024
Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>
3 tasks
|
@thehowl, it looks good to merge soon. |
|
I added some additional rules for /examples; it should now be good to go. |
deelawn
approved these changes
May 2, 2024
thehowl
added a commit
that referenced
this pull request
May 2, 2024
Addresses #1801 (comment) Related with #1765 --------- Co-authored-by: Morgan <morgan@morganbaz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to add more CODEOWNERS rules for specific directories.
WIP still. Figuring out some more rules for the
/examples/directory. Feel free to take a look though.