feat(txtar): create user from passed mnemonic, account and index #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mnemonic, account, index can be provided to derive certain address
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1879 +/- ##
=======================================
Coverage 47.74% 47.75%
=======================================
Files 393 393
Lines 61629 61671 +42
=======================================
+ Hits 29424 29449 +25
- Misses 29734 29744 +10
- Partials 2471 2478 +7 ☔ View full report in Codecov by Sentry. |
gfanton
requested changes
Apr 3, 2024
Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>
Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>
Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>
gfanton
approved these changes
Apr 3, 2024
leohhhn
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adduserin txtar creates user with bit of randomness which results different address are being added for every time we run txtar testing.This PR implements
adduserfrom, which creates a user from given mnemonic (optionally account and index can be also passed to derive different address from same mnemonic)Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description