Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ufmt multi-byte fix. #1889

Merged
merged 11 commits into from
Apr 8, 2024
Merged

fix: ufmt multi-byte fix. #1889

merged 11 commits into from
Apr 8, 2024

Conversation

MalekLahbib
Copy link
Contributor

@MalekLahbib MalekLahbib commented Apr 4, 2024

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Apr 4, 2024
@MalekLahbib MalekLahbib changed the title added todolist pckg and realm fix: ufmt multi-byte fix. Apr 4, 2024
@MalekLahbib MalekLahbib marked this pull request as ready for review April 4, 2024 16:25
@MalekLahbib MalekLahbib requested review from a team as code owners April 4, 2024 16:25
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.03%. Comparing base (831bb6f) to head (398805a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1889      +/-   ##
==========================================
- Coverage   47.74%   45.03%   -2.71%     
==========================================
  Files         393      464      +71     
  Lines       61629    67975    +6346     
==========================================
+ Hits        29424    30614    +1190     
- Misses      29734    34788    +5054     
- Partials     2471     2573     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 🙏

Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

@leohhhn leohhhn linked an issue Apr 8, 2024 that may be closed by this pull request
@leohhhn leohhhn merged commit 1f14e7b into gnolang:master Apr 8, 2024
188 checks passed
@MalekLahbib MalekLahbib deleted the ufmt branch October 7, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

ufmt doesn't display the unicode emojis correctly
4 participants