feat: DAO SDK #1925

n0izn0iz · 2024-04-12T16:50:07Z

This implement a DAO SDK inspired by DA0-DA0

The code in this PR has been extracted from #1154 and cleaned (reviews on the previous PR should have been addressed)

It includes:

Interfaces for the DAO gno.land/p/demo/dao_maker/dao_interfaces
A reference implementation for the core of the DAO gno.land/p/demo/dao_maker/dao_core
A membership-based voting module gno.land/p/demo/dao_maker/dao_voting_group
A single-choice proposal module gno.land/p/demo/dao_maker/dao_proposal_single
An example DAO gno.land/r/demo/dao_maker/dao_realm
A registry to dynamically interact with any registered DAO using it's address gno.land/r/demo/dao_maker/dao_registry

For usage see the tutorial, it is integrated into docusaurus

There is an example membership-based DAO at gno.land/r/demo/teritori/dao_realm that can administer itself and a grc20 token at gno.land/r/demo/teritori/tori

Here is it's GnoWeb Render:

This powers the "Organizations" feature of Teritori dApp on Gno as shown below

The DAO creation UI uses a Gno template and instantiates a new realm.

Contributors' checklist...

Added new tests, or not needed, or not feasible
Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
Updated the official documentation or not needed
No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
Added references to related issues and PRs
Provided any useful hints for running manual tests
Added new benchmarks to generated graphs, if any. More info here.

Signed-off-by: Norman Meier <norman@berty.tech>

Signed-off-by: Norman Meier <norman@samourai.coop>

n0izn0iz · 2024-05-04T10:33:44Z

Thanks for the review @leohhhn, I addressed your comments

I have two remarks to spark discussion around guidelines:

Adding periods everywhere is considered a bad ux practice by google
Tutorials should be playful instead of formal

The use of humor in the college classroom has been researched extensively (see Segrist & Hupp, 2015 who summarized 41 years of literature on humor in the college classroom) and has been shown to have many benefits for students (Banas, Dunbar, Rodriguez & Liu, 2011; Garner, 2006; Huss & Estep, 2016; Pollio, 2002), some of which are:
An increase in learning.
An increase in self-motivation.
An increase in class attendance.
An increase in test performance.
An increase in divergent thinking.
An increase of interest in learning.
A reduction of anxiety and stress in dealing with difficult material.
The creation of a positive social and emotional learning environment.
The creation of a common psychological bond between students and faculty.

Signed-off-by: Norman Meier <norman@samourai.coop>

…alm name Signed-off-by: Norman Meier <norman@samourai.coop>

elix1er · 2024-05-07T17:12:06Z

impressive work, keep grinding

leohhhn

Left some minor suggestions to the docs page. Otherwise we should be good to go.

Sorry for the delay, and great work.

docs/how-to-guides/creating-dao.md

Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>

moul · 2024-07-07T16:14:11Z

examples/gno.land/p/demo/users/types.gno

@@ -12,3 +16,14 @@ func (aon AddressOrName) GetName() (string, bool) {
 	}
 	return "", false
 }
+
+func (aon AddressOrName) IsValid() bool {


what about using users.Resolve(aon).IsValid()?

can't call the realm method users.Resolve from a p package

moul · 2024-07-07T16:20:17Z

examples/gno.land/p/demo/dao_maker/havl/havl.gno

@@ -0,0 +1,133 @@
+package havl


can you add more info about what is this package about?

it looks like something that should be located in p/demo/havl.

and add some tests.

-> could eventually have it's own PR.

moul · 2024-07-07T16:24:29Z

examples/gno.land/p/demo/dao_maker/jsonutil/gno.mod

@@ -0,0 +1,7 @@
+module gno.land/p/demo/dao_maker/jsonutil


The current p/demo/json library should be suitable for your needs.

I'm against having any JSON library written in userland because I expect that we can use @gfanton's #1776 and avoid any boilerplate code that isn't either for humans (rendering) or for other contracts (imports). Generally, anything about marshalling doesn't fall into these categories.

In the meantime, you can reuse the existing JSON library if needed. However, as soon as possible, I expect we can delete it completely. Additionally, if possible, I expect we don't merge any new JSON library in the meantime.

this extends p/demo/json

moul · 2024-07-07T16:25:31Z

examples/gno.land/p/demo/dao_maker/dao_voting_group/voting_group.gno

+func (v *VotingGroup) Render(path string) string {
+	sb := strings.Builder{}
+	sb.WriteString("Member count: ")
+	sb.WriteString(strconv.FormatUint(uint64(v.MemberCount(havl.Latest)), 10))


Suggested change

sb.WriteString(strconv.FormatUint(uint64(v.MemberCount(havl.Latest)), 10))

sb.WriteString(ufmt.Sprintf("%d", havl.Latest))

moul · 2024-07-07T16:26:37Z

examples/gno.land/p/demo/dao_maker/dao_voting_group/voting_group.gno

+	g.powerByAddr.Iterate(start, end, height, func(k string, v interface{}) bool {
+		if limit > 0 && uint64(len(members)) >= limit {
+			return true
+		}


You can use avl.Tree.IterateByOffset.

moul · 2024-07-07T16:27:21Z

examples/gno.land/p/demo/dao_maker/dao_voting_group/voting_group.gno

+}
+
+func (g *VotingGroup) MemberCount(height int64) uint32 {
+	val, ok := g.memberCount.Get("", height)


isn't avl.Tree.Size enough for you?

moul · 2024-07-07T16:31:31Z

examples/gno.land/r/demo/dao_maker/tori/tori.gno

can you move this to gno.land/r/teritori/tori?

moul · 2024-07-07T17:48:25Z

examples/gno.land/p/demo/dao_maker/dao_interfaces/messages.gno

+type ExecutableMessage interface {
+	ToJSON() *json.Node
+	FromJSON(ast *json.Node)
+
+	String() string
+	Type() string
+}


why is this needed?

moul

There are several interesting aspects in that PR, but there is too much work to review at the moment. Therefore, I will mark it as "request changes" to allow more time for a thorough review.

A high-level suggestion I can provide is to:

Simplify the codebase by reducing the number of packages, files, functions, types, and boilerplate, and avoiding the use of JSON, etc. Consider merging some packages together.
Improve the naming conventions. For instance, use more specific names like "Teritori Realms" and "Daomaker" (a better name could facilitate faster merging, as "Daomaker" is currently too generic and sounds overly official, while "Teritori" would make it easier to integrate).

from gnolang/gno#1925 Signed-off-by: Norman Meier <norman@samourai.coop>

* feat: dao_maker from gnolang/gno#1925 Signed-off-by: Norman Meier <norman@samourai.coop> * tmp Signed-off-by: Norman Meier <norman@samourai.coop> * chore: add back ujson and fix social feed Signed-off-by: Norman Meier <norman@samourai.coop> * chore: remove artifact Signed-off-by: Norman Meier <norman@samourai.coop> * chore: remove artifact Signed-off-by: Norman Meier <norman@samourai.coop> * chore: ci fix Signed-off-by: Norman Meier <norman@samourai.coop> * fix: revert bad change Signed-off-by: Norman Meier <norman@samourai.coop> --------- Signed-off-by: Norman Meier <norman@samourai.coop>

n0izn0iz added 30 commits April 10, 2024 19:11

feat: DA0-DA0 port

f677f1c

Signed-off-by: Norman Meier <norman@berty.tech>

feat: social feed and moderation dao by @hthieu1110

135287a

chore: remove duplicates and unversion packages

6cc1280

Signed-off-by: Norman Meier <norman@berty.tech>

chore: reset gnovm changes

ce2465a

Signed-off-by: Norman Meier <norman@berty.tech>

fix: make social feed and moderation work with latest dao packages

d375b61

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move daodao contracts under teritori dir

d8800be

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move ujson under teritori dir

0fa396f

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move binutils under teritori dir

86d4fcc

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move flags_index under teritori dir

fd7a5b3

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move havl under teritori dir

9c89420

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move markdown_utils under teritori dir

06d722f

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move utf16 under teritori dir

f9f376d

Signed-off-by: Norman Meier <norman@berty.tech>

chore: update modboards golden test

3532d57

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move dao_realm under teritori dir

380f7e7

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move dao_registry under teritori dir

3d12ce1

Signed-off-by: Norman Meier <norman@berty.tech>

chore: fork groups into teritori dir

6a8e185

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move modboards under teritori dir

6ba2ba2

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move social_feeds under teritori dir

3ab1751

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move social_feeds_dao under teritori dir

13b1337

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move tori under teritori dir

b416f44

Signed-off-by: Norman Meier <norman@berty.tech>

chore: update modboards golden test

f320770

Signed-off-by: Norman Meier <norman@berty.tech>

chore: reset gnovm changes

85302e4

Signed-off-by: Norman Meier <norman@berty.tech>

chore: reset .gitignore changes

69dd461

Signed-off-by: Norman Meier <norman@berty.tech>

feat: escrow contract by @go7066

507039d

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move escrow under teritori dir

5a77310

Signed-off-by: Norman Meier <norman@berty.tech>

feat: cosmos-style voting DAO by @go7066

0c01047

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move gnodaos under teritori dir

9e826d7

Signed-off-by: Norman Meier <norman@berty.tech>

chore: add disclaimer in gnodaos

911d788

Signed-off-by: Norman Meier <norman@berty.tech>

feat: justicedao and vrf by @go7066

ea09b63

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move justicedao and vrf under teritori dir

225aa19

Signed-off-by: Norman Meier <norman@berty.tech>

chore: improve doc

e701f83

Signed-off-by: Norman Meier <norman@samourai.coop>

n0izn0iz added 7 commits May 4, 2024 13:15

chore: improve docs

66a4854

Signed-off-by: Norman Meier <norman@samourai.coop>

chore: improve docs

5eaf156

Signed-off-by: Norman Meier <norman@samourai.coop>

chore: better comment

f51719c

Signed-off-by: Norman Meier <norman@samourai.coop>

chore: rename teritori -> dao-maker

7956e63

Signed-off-by: Norman Meier <norman@samourai.coop>

Merge remote-tracking branch 'origin/master' into daosdk

9c4463d

chore: mod tidy

00b499f

Signed-off-by: Norman Meier <norman@samourai.coop>

chore: rename dao-maker -> dao_maker because - is not supported in re…

58a8385

…alm name Signed-off-by: Norman Meier <norman@samourai.coop>

n0izn0iz added 2 commits May 14, 2024 14:01

Merge branch 'master' into daosdk

1b78823

Merge branch 'master' into daosdk

f4f54a2

michelleellen mentioned this pull request May 22, 2024

Minutes: Public Dev Calls [every Wednesday] gnolang/meetings#37

Open

zxxma mentioned this pull request May 22, 2024

Teritori's Builder Journey gnolang/hackerspace#7

Open

leohhhn approved these changes Jun 12, 2024

View reviewed changes

n0izn0iz and others added 2 commits June 17, 2024 19:03

chore: update docs

db663c7

Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>

chore: update docs

63e3de2

Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>

moul reviewed Jul 7, 2024

View reviewed changes

examples/gno.land/r/demo/dao_maker/tori/tori.gno

Copy link

Member

moul Jul 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this to gno.land/r/teritori/tori?

moul reviewed Jul 7, 2024

View reviewed changes

moul requested changes Jul 8, 2024

View reviewed changes

moul marked this pull request as draft July 8, 2024 01:12

n0izn0iz added a commit to TERITORI/teritori-dapp that referenced this pull request Sep 8, 2024

feat: dao_maker

73b6952

from gnolang/gno#1925 Signed-off-by: Norman Meier <norman@samourai.coop>

n0izn0iz mentioned this pull request Sep 8, 2024

feat: dao_maker TERITORI/teritori-dapp#1267

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: DAO SDK #1925

feat: DAO SDK #1925

n0izn0iz commented Apr 12, 2024 •

edited

Loading

n0izn0iz commented May 4, 2024 •

edited

Loading

elix1er commented May 7, 2024

leohhhn left a comment

moul Jul 7, 2024

n0izn0iz Sep 5, 2024

moul Jul 7, 2024 •

edited

Loading

moul Jul 7, 2024

n0izn0iz Sep 5, 2024

moul Jul 7, 2024

moul Jul 7, 2024

moul Jul 7, 2024

moul Jul 7, 2024

moul Jul 7, 2024

moul left a comment

	sb.WriteString(strconv.FormatUint(uint64(v.MemberCount(havl.Latest)), 10))
	sb.WriteString(ufmt.Sprintf("%d", havl.Latest))

feat: DAO SDK #1925

Are you sure you want to change the base?

feat: DAO SDK #1925

Conversation

n0izn0iz commented Apr 12, 2024 • edited Loading

n0izn0iz commented May 4, 2024 • edited Loading

elix1er commented May 7, 2024

leohhhn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moul Jul 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moul left a comment

Choose a reason for hiding this comment

n0izn0iz commented Apr 12, 2024 •

edited

Loading

n0izn0iz commented May 4, 2024 •

edited

Loading

moul Jul 7, 2024 •

edited

Loading