-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move gnofaucet
to contribs
#1955
fix: move gnofaucet
to contribs
#1955
Conversation
@gfanton Would appreciate the help with the |
5e267d4
to
6a0bceb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1955 +/- ##
==========================================
- Coverage 47.78% 45.16% -2.62%
==========================================
Files 393 465 +72
Lines 61608 68087 +6479
==========================================
+ Hits 29437 30752 +1315
- Misses 29701 34758 +5057
- Partials 2470 2577 +107 ☔ View full report in Codecov by Sentry. |
I will improve and revise the entire Dockerfile later. For now, it seems satisfactory with minimal changes. |
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
6a0bceb
to
971e5b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I was reading through the docs and saw that there is never a command which references how to install the faucet itself.
So, good, maybe @leohhhn can add that later to the related docs pages for gnofaucet.
Just one note about the CI, then we should be good to go.
## Description This PR moves the `gnofaucet` codebase from `gno.land/cmd/gnofaucet` to `./contribs/gnofaucet`, as this is causing API shenanigans when any `gno` API used by the `gnolang/faucet` library is changed. Thank you @gfanton for resolving the Docker funny business 🙏 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com> Co-authored-by: gfanton <8671905+gfanton@users.noreply.github.com>
Description
This PR moves the
gnofaucet
codebase fromgno.land/cmd/gnofaucet
to./contribs/gnofaucet
, as this is causing API shenanigans when anygno
API used by thegnolang/faucet
library is changed.Thank you @gfanton for resolving the Docker funny business 🙏
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description