-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): add vhs gif #2012
base: master
Are you sure you want to change the base?
feat(docs): add vhs gif #2012
Conversation
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2012 +/- ##
==========================================
+ Coverage 45.62% 48.37% +2.75%
==========================================
Files 445 409 -36
Lines 66233 62070 -4163
==========================================
- Hits 30219 30029 -190
+ Misses 33521 29539 -3982
- Partials 2493 2502 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strange filename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you check if https://github.com/nbedos/termtosvg could work? It seems to be more git-friendly than binary gif?
@moul The key point of VHS is tape files, they are easily maintainable and readable, and you don't have to record it, so the result is always predictable. It also come with cool features like the capacity to produce frame screenshots or integrating hidden parts for a setup phase. Also, as VHS is written in Go, I have that really distant idea to potentially integrate VHS as a module for txtar. (as external tool ofc) This integration could replace tape file to create GIFs + Screenshot + Markdown Code Block, transforming the doc into a living testing integration 😎 |
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months. |
This PR sets up
VHS
to generate GIFs, ensuring we always have up-to-date GIFs for documentation. I included sample tapes to demonstrate how to proceed.Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description