Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add vhs gif #2012

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat(docs): add vhs gif #2012

wants to merge 3 commits into from

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented May 1, 2024

This PR sets up VHS to generate GIFs, ensuring we always have up-to-date GIFs for documentation. I included sample tapes to demonstrate how to proceed.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.37%. Comparing base (de2fc45) to head (246cf27).
Report is 463 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2012      +/-   ##
==========================================
+ Coverage   45.62%   48.37%   +2.75%     
==========================================
  Files         445      409      -36     
  Lines       66233    62070    -4163     
==========================================
- Hits        30219    30029     -190     
+ Misses      33521    29539    -3982     
- Partials     2493     2502       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange filename

Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could you check if https://github.com/nbedos/termtosvg could work? It seems to be more git-friendly than binary gif?

@moul moul mentioned this pull request May 1, 2024
@gfanton
Copy link
Member Author

gfanton commented May 1, 2024

Could you check if nbedos/termtosvg could work? It seems to be more git-friendly than binary gif?

@moul
Looks like the repo has been archived.
The concept of SVG is cool, but even though it's indeed a readable format, it ultimately appears to not be that easily readable in this particular sub-format. Also, I don't really like the fact of depending on JavaScript to run.

The key point of VHS is tape files, they are easily maintainable and readable, and you don't have to record it, so the result is always predictable. It also come with cool features like the capacity to produce frame screenshots or integrating hidden parts for a setup phase.
If your concern is more about git, it can also produce golden ascii files that are git friendly so we can certainly play around that capacity.

Also, as VHS is written in Go, I have that really distant idea to potentially integrate VHS as a module for txtar. (as external tool ofc) This integration could replace tape file to create GIFs + Screenshot + Markdown Code Block, transforming the doc into a living testing integration 😎

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@leohhhn leohhhn self-requested a review May 6, 2024 22:15
@leohhhn leohhhn changed the title feat(doc): add vhs gif feat(docs): add vhs gif May 6, 2024
Copy link

This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months.

@github-actions github-actions bot added Stale and removed Stale labels Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Status: In Progress
Status: No status
Status: Triage
Development

Successfully merging this pull request may close these issues.

3 participants