chore: make contribs/ ci and makefiles dynamic #2013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2013 +/- ##
==========================================
+ Coverage 46.69% 48.39% +1.70%
==========================================
Files 492 409 -83
Lines 69700 62038 -7662
==========================================
- Hits 32546 30026 -2520
+ Misses 34442 29512 -4930
+ Partials 2712 2500 -212 ☔ View full report in Codecov by Sentry. |
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
moul
changed the title
Signed-off-by: moul <94029+moul@users.noreply.github.com>
thehowl
reviewed
May 2, 2024
Signed-off-by: moul <94029+moul@users.noreply.github.com>
|
Continues in #2318 |
moul
added a commit
that referenced
this pull request
Jul 4, 2024
Continues #2013 > People should focus on their contributions in the `contribs/MYFOLDER` without updating a shared `Makefile` + `.github/contribs/*.yml`. The CI part has been completed in #2040. This pull request handles the Makefile portion. --------- Signed-off-by: moul <94029+moul@users.noreply.github.com>
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
Continues gnolang#2013 > People should focus on their contributions in the `contribs/MYFOLDER` without updating a shared `Makefile` + `.github/contribs/*.yml`. The CI part has been completed in gnolang#2040. This pull request handles the Makefile portion. --------- Signed-off-by: moul <94029+moul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly, I'm not a fan of "magic makefiles." However, for this folder, it's best to proceed this way. People should focus on their contributions in the
contribs/MYFOLDERwithout updating a sharedMakefile+.github/contribs/*.yml.Related with #2040.