-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): setup docker build cache #2062
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2062 +/- ##
==========================================
- Coverage 54.65% 54.64% -0.02%
==========================================
Files 583 583
Lines 78508 78508
==========================================
- Hits 42909 42901 -8
- Misses 32385 32393 +8
Partials 3214 3214
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4383c92
to
84acee8
Compare
After mutliple tries, i'm not sure it's improve a lot the build time. probably because it's concurrent build. |
@albttx can you please update the branch to the latest |
@zivkovicmilos So i fixed / rebased this PR, and added a workflow that didn't push the Docker image (this can be remove if you want). The idea is to add a simple dockerfile that could be use by dev (because the goreleaser version require the go toolchain locally, this is a more "pure" docker image where the binaries are built inside the images. This Dockerfile is require for me for the ci/portal-loop test! |
@zivkovicmilos is this still relevant? |
@sw360cab @zivkovicmilos the question still stands :) |
@Kouteki I am working on a template of optimized image in the dedicated gno infra repository |
This PR can be close |
Build docker images as test, and let it for developers