-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: register hljs plaintext language #2103
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2103 +/- ##
=======================================
Coverage 47.02% 47.02%
=======================================
Files 578 578
Lines 77571 77571
=======================================
Hits 36477 36477
Misses 38059 38059
Partials 3035 3035
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where does this new highlight file come from?
it doesn't seem to match what I get when using the download page with go and plaintext...
@thehowl (and json), I customized it myself but do you prefer this one? :) |
I don't have strong preferences either way BTW; it's just that minified code is never nice to review, and as a matter of principle, I think minified code should be either:
otherwise, we're vulnerable to an attack by injecting malicious code into minified code (which we don't review as accurately). Not saying you are, but it is a matter of principle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matches what I'd expect, LGTM
@thehowl I agree, I would love to have/bring some basic front-end tasks pipelining to minify styles and scripts (automatically on CI for example). Now it's a real burden to work on it (and to test it)... Maybe something we could discuss about while we revamp gnoweb UX and front next weeks? |
<!-- please provide a detailed description of the changes made in this pull request. --> This PR aims to fix the `md` rendering issue when `plaintext` is summon by marked.js / hljs. It just registers the `plaintext` module into `hljs` js lib. Fixes: gnolang#2084
This PR aims to fix the
md
rendering issue whenplaintext
is summon by marked.js / hljs. It just registers theplaintext
module intohljs
js lib.Fixes: #2084