fix: limitation for length of package/realm path

tm2/pkg/std/memfile.go

@@ -38,9 +38,16 @@ func (mempkg *MemPackage) IsEmpty() bool {
 }
 
 var (
-	rePkgName      = regexp.MustCompile(`^[a-z][a-z0-9_]*$`)
-	rePkgOrRlmPath = regexp.MustCompile(`^gno\.land\/(?:p|r)(?:\/_?[a-z]+[a-z0-9_]*)+$`)
-	reFileName     = regexp.MustCompile(`^([a-zA-Z0-9_]*\.[a-z0-9_\.]*|LICENSE|README)$`)
+	rePkgName = regexp.MustCompile(`^[a-z][a-z0-9_]*$`)
+	/*
+		in case we use RE2 external lib (e.g. dlclark/regexp2), we can do this
+		^(?=.{0,256}$)gno\.land\/(?:p|r)(?:\/_?[a-z]+[a-z0-9_]*)+$
+		with lookahead operation to limit lenght
+		but for now we just check the pkgPath's len instead of.
+	*/
+	rePkgOrRlmPath     = regexp.MustCompile(`^gno\.land\/(?:p|r)(?:\/_?[a-z]+[a-z0-9_]*)+$`)
+	reFileName         = regexp.MustCompile(`^([a-zA-Z0-9_]*\.[a-z0-9_\.]*|LICENSE|README)$`)
+	rePkgOrRlmLenLimit = 256
 )
 
 // path must not contain any dots after the first domain component.
@@ -58,6 +65,9 @@ func (mempkg *MemPackage) Validate() error {
 	if !rePkgOrRlmPath.MatchString(mempkg.Path) {
 		return fmt.Errorf("invalid package/realm path %q, failed to match %q", mempkg.Path, rePkgOrRlmPath)
 	}
+	if !isValidLength(mempkg.Path, rePkgOrRlmLenLimit) {
+		return fmt.Errorf("invalid length of package/realm path: %v which limitation is %v", len(mempkg.Path), rePkgOrRlmLenLimit)
+	}
 	// enforce sorting files based on Go conventions for predictability
 	sorted := sort.SliceIsSorted(
 		mempkg.Files,
@@ -98,3 +108,7 @@ func SplitFilepath(filepath string) (dirpath string, filename string) {
 		return strings.Join(parts, "/"), ""
 	}
 }
+
+func isValidLength(pkgPath string, limitation int) bool {
+	return len(pkgPath) <= limitation
+}

tm2/pkg/std/memfile_test.go

@@ -190,7 +190,16 @@ func TestRePkgOrRlmPath(t *testing.T) {
 			expected: false,
 		},
 	}
-
+	testLengthTable := []struct{
+		desc, in string
+		expected bool
+	}{
+		{
+		desc:     "Longer Than Limit",
+		in:       "gno.land/r/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very/very",
+		expected: false,
+		},
+	}
 	for _, tc := range testTable {
 		tc := tc
 		t.Run(tc.desc, func(t *testing.T) {
@@ -199,4 +208,11 @@ func TestRePkgOrRlmPath(t *testing.T) {
 			assert.Equal(t, tc.expected, rePkgOrRlmPath.MatchString(tc.in))
 		})
 	}
+	for _, tc := range testLengthTable {
+		tc := tc
+		t.Run(tc.desc, func(t *testing.T) {
+			t.Parallel()
+			assert.Equal(t, tc.expected, isValidLength(tc.in, rePkgOrRlmLenLimit))
+		})
+	}
 }