feat(Gnovm/std): GasUsed function for std
#2149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thehowl can you take a look on this. I really need your opinion. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2149 +/- ##
==========================================
- Coverage 49.93% 49.93% -0.01%
==========================================
Files 576 577 +1
Lines 77828 77841 +13
==========================================
+ Hits 38862 38868 +6
- Misses 35840 35849 +9
+ Partials 3126 3124 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thehowl
reviewed
Jun 18, 2024
| @@ -13,6 +13,8 @@ func IsOriginCall() bool // injected | |||
| func GetChainID() string // injected | |||
| func GetHeight() int64 // injected | |||
|
|
|||
| func GasUsed() int64 // injected | |||
There was a problem hiding this comment.
Please place this next to the other injected functions (and align // injected), please!
Comment on lines
+12
to
+26
| var ( | ||
| gasUsedInvoked = "GasUsedCalled" | ||
| /* | ||
| Consider where to save this config | ||
| defaultGasConfig = store.DefaultGasConfig() | ||
| */ | ||
| // defaultGasConfig = int64(1000) | ||
| defaultInvokeCost = store.DefaultGasConfig().ReadCostFlat | ||
| ) | ||
|
|
||
| // DefaultCost will be consumed whenever GasUsed is called, now set it ReadCostPerByte | ||
| func GasUsed(m *gno.Machine) int64 { | ||
| m.GasMeter.ConsumeGas(defaultInvokeCost, gasUsedInvoked) | ||
| return m.GasMeter.GasConsumedToLimit() | ||
| } |
There was a problem hiding this comment.
Don't consume gas here; we'll need to benchmark all native functions and add a cost on another occasion.
|
Apologies for the late review |
|
Fixes #2467 |
9 tasks
|
Closed due to #2571 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the descriptionAs discussion in #1998, We should have this gasUsed() std function with two potential use cases:
This PR defines a
GasUsed()func and adefaultInvokeCostin gas (?) withinstdpackage, and whenever theGasUsed()is invoked, the GasMeter will consume this amount, returns theGasConsumedToLimit.(?) What is a reasonable number for this amount? I just set it to 1000 (store.DefaultGasConfig().ReadCostFlat).
TODO: Should we move the default cost config into
store.DefaultGasConfig?