Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use tag latest for latest releases, nightly for nightly versions #2175

Merged
merged 2 commits into from
May 26, 2024

Conversation

ajnavarro
Copy link
Contributor

@ajnavarro ajnavarro commented May 23, 2024

Added a new tag for them: nightly.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@ajnavarro ajnavarro requested review from moul and a team as code owners May 23, 2024 13:05
@ajnavarro ajnavarro requested review from gfanton and removed request for a team May 23, 2024 13:05
Added a new tag for them: master.

Signed-off-by: Antonio Navarro <antnavper@gmail.com>
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.27%. Comparing base (16ed32f) to head (bdd3b79).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2175      +/-   ##
==========================================
+ Coverage   49.06%   49.27%   +0.20%     
==========================================
  Files         576      576              
  Lines       77593    78004     +411     
==========================================
+ Hits        38069    38433     +364     
- Misses      36431    36440       +9     
- Partials     3093     3131      +38     
Flag Coverage Δ
contribs/gnodev 24.18% <ø> (+0.03%) ⬆️
contribs/gnofaucet 15.31% <ø> (+0.85%) ⬆️
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 61.69% <ø> (ø)
gnovm 42.21% <ø> (+0.30%) ⬆️
misc/autocounterd 0.00% <ø> (ø)
misc/genproto 0.00% <ø> (ø)
misc/genstd 73.90% <ø> (ø)
misc/goscan 0.00% <ø> (ø)
misc/logos 17.68% <ø> (ø)
misc/loop 0.00% <ø> (ø)
tm2 54.80% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I think nightly is better, master if it exists should be the latest commit on master...

.github/workflows/nightlies.yml Outdated Show resolved Hide resolved
…id problems in the future

Signed-off-by: Antonio Navarro <antnavper@gmail.com>
@ajnavarro
Copy link
Contributor Author

@thehowl I moved the tag from master to nightly, it makes much more sense.

@ajnavarro ajnavarro requested a review from thehowl May 24, 2024 09:11
@thehowl thehowl changed the title fix: Nightlies are not latest docker images. ci: use tag latest for latest releases, nightly for nightly versions May 24, 2024
@zivkovicmilos zivkovicmilos self-requested a review May 24, 2024 16:16
@zivkovicmilos zivkovicmilos merged commit bb776f0 into master May 26, 2024
82 checks passed
@zivkovicmilos zivkovicmilos deleted the feat/nightlies-not-latest branch May 26, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants