fix(gnoclient): Return error when getting keypair information #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2300 +/- ##
==========================================
- Coverage 54.68% 54.68% -0.01%
==========================================
Files 582 582
Lines 78330 78345 +15
==========================================
+ Hits 42838 42840 +2
- Misses 32285 32293 +8
- Partials 3207 3212 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This PR is not currently fully covered by unit tests, however I have added the necessary unit tests for signers in this PR #2209 |
deelawn
approved these changes
Jun 7, 2024
ltzmaxwell
approved these changes
Jun 11, 2024
zivkovicmilos
approved these changes
Jun 12, 2024
Co-authored-by: Miloš Živković <milos@zmilos.com>
moul
reviewed
Jun 13, 2024
moul
approved these changes
Jun 19, 2024
auto-merge was automatically disabled
June 20, 2024 04:28
Head branch was pushed to by a user without write access
github-actions
bot
added
the
🧾 package/realm
|
@linhpn99 Please don't press the "re-request review" button if you've received approvals |
thehowl
approved these changes
Jun 20, 2024
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
…g#2300) Relate to gnolang#2133 <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Miloš Živković <milos@zmilos.com> Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relate to #2133
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description