feat: add p/nestedpkg #2342
Merged
feat: add p/nestedpkg #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moul <94029+moul@users.noreply.github.com>
moul
requested review from
thehowl and
ltzmaxwell
and removed request for
a team
github-actions
bot
added
the
🧾 package/realm
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
deelawn
reviewed
Jun 20, 2024
deelawn
reviewed
Jun 27, 2024
deelawn
approved these changes
Jun 28, 2024
Signed-off-by: moul <94029+moul@users.noreply.github.com>
zivkovicmilos
added a commit
that referenced
this pull request
Jul 6, 2024
This reverts commit 77ceda4.
7 tasks
moul
pushed a commit
that referenced
this pull request
Jul 6, 2024
## Description This PR reverts commit 77ceda4, #2342, because of a cyclic `gno.mod` import that's causing the node to not be able to generate genesis transactions and start. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
This package demonstrates a new access control pattern relying on package paths. It considers that the gnolang#1107 feature is already implemented to rely on the built-in security. You can see an ongoing usage in gnolang#2334. --------- Signed-off-by: moul <94029+moul@users.noreply.github.com>
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
## Description This PR reverts commit 77ceda4, gnolang#2342, because of a cyclic `gno.mod` import that's causing the node to not be able to generate genesis transactions and start. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
thehowl
added a commit
that referenced
this pull request
Jul 24, 2024
…#2334) Depends on #2342 cc @jeronimoalbi --------- Signed-off-by: moul <94029+moul@users.noreply.github.com> Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com> Co-authored-by: Morgan <morgan@morganbaz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package demonstrates a new access control pattern relying on package paths.
It considers that the #1107 feature is already implemented to rely on the built-in security.
You can see an ongoing usage in #2334.