Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tm2): Add missing unit tests for tm2/pkg/crypto/client #2350

Closed
wants to merge 32 commits into from

Conversation

linhpn99
Copy link
Contributor

@linhpn99 linhpn99 commented Jun 13, 2024

Blocked by #2309

From @moul 's request to add unit tests, I realized there are many code sections (maketx, call, query, etc.) that are not covered by unit tests. Obviously, this PR is created to address all of them :)

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@linhpn99 linhpn99 marked this pull request as draft June 13, 2024 10:02
@github-actions github-actions bot added 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Jun 13, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.17%. Comparing base (95115c0) to head (d1a7e29).
Report is 60 commits behind head on master.

Files Patch % Lines
tm2/pkg/crypto/keys/client/broadcast.go 55.55% 2 Missing and 2 partials ⚠️
tm2/pkg/crypto/keys/client/send.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2350      +/-   ##
==========================================
+ Coverage   55.02%   55.17%   +0.15%     
==========================================
  Files         595      595              
  Lines       79662    79669       +7     
==========================================
+ Hits        43832    43960     +128     
+ Misses      32514    32384     -130     
- Partials     3316     3325       +9     
Flag Coverage Δ
contribs/gnodev 25.65% <ø> (-0.35%) ⬇️
contribs/gnofaucet 14.46% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related labels Jul 13, 2024
@linhpn99 linhpn99 changed the title Add missing unit tests for tm2/pkg/crypto/client feat(tm2): Add missing unit tests for tm2/pkg/crypto/client Jul 13, 2024
@linhpn99 linhpn99 closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant