fix(gnovm): source location always precise with line and column #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The column number was not stored in the GnoVM location. A `Nonce`
field was used to distinguished 2 block nodes on the same line.
This was applied only to block nodes, not expressions or statements.
As a result, the node location was the same for all expressions and
statements located at the same source line. This change ensures the
uniqueness of location for all nodes, in addition to providing an
accurate position in source code.
We replace `Nonce` by `Column`, computed by the Go tokenizer (the same
as line numbers). Column is always included in all AST nodes, and the
location string has a uniform format.
With this change it is now possible for the debugger to step in
infinite loops on one line like:
`for { i++; println(i) }`
This change is also necessary for a correct accounting for code
coverage, and also may gas accounting.
mvertes
requested review from
jaekwon,
moul,
piux2,
deelawn and
thehowl
as code owners
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2362 +/- ##
==========================================
+ Coverage 54.68% 54.71% +0.03%
==========================================
Files 583 582 -1
Lines 78503 78407 -96
==========================================
- Hits 42928 42902 -26
+ Misses 32368 32293 -75
- Partials 3207 3212 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The column number was not stored in the GnoVM location. A `Nonce`
field was used to distinguished 2 block nodes on the same line.
This was applied only to block nodes, not expressions or statements.
As a result, the node location was the same for all expressions and
statements located at the same source line. This change ensures the
uniqueness of location for all nodes, in addition to providing an
accurate position in source code.
We replace `Nonce` by `Column`, computed by the Go tokenizer (the same
as line numbers). Column is always included in all AST nodes, and the
location string has a uniform format.
With this change it is now possible for the debugger to step in
infinite loops on one line like:
`for { i++; println(i) }`
This change is also necessary for a correct accounting for code
coverage, and also may gas accounting.
thehowl
approved these changes
Jun 20, 2024
|
please merge and fix conflicts 🙏 cc @deelawn for a second review |
ajnavarro
approved these changes
Jun 25, 2024
github-actions
bot
added
the
📦 ⛰️ gno.land
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
…ang#2362) The column number was not stored in the GnoVM location. A `Nonce` field was used to distinguished 2 block nodes on the same line. This was applied only to block nodes, not expressions or statements. As a result, the node location was the same for all expressions and statements located at the same source line. This change ensures the uniqueness of location for all nodes, in addition to providing an accurate position in source code. We replace `Nonce` by `Column`, computed by the Go tokenizer (the same as line numbers). Column is always included in all AST nodes, and the location string has a uniform format. With this change it is now possible for the debugger to step in infinite loops on one line like: `for { i++; println(i) }` This change is also necessary for a correct accounting for code coverage, and also may be gas accounting. Note: as `Nonce` is renamed to `Column` in protocol definitions (type and index unchanged), it may qualify as a BREAKING CHANGE, but I'm not completely sure of that. <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [*] Added new tests, or not needed, or not feasible - [*] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [*] Updated the official documentation or not needed - [*] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [*] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The column number was not stored in the GnoVM location. A
Noncefield was used to distinguished 2 block nodes on the same line. This was applied only to block nodes, not expressions or statements.As a result, the node location was the same for all expressions and statements located at the same source line. This change ensures the uniqueness of location for all nodes, in addition to providing an accurate position in source code.
We replace
NoncebyColumn, computed by the Go tokenizer (the same as line numbers). Column is always included in all AST nodes, and the location string has a uniform format.With this change it is now possible for the debugger to step in infinite loops on one line like:
for { i++; println(i) }This change is also necessary for a correct accounting for code coverage, and also may be gas accounting.
Note: as
Nonceis renamed toColumnin protocol definitions (type and index unchanged),it may qualify as a BREAKING CHANGE, but I'm not completely sure of that.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description