-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: docs linter improvements #2404
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2404 +/- ##
========================================
Coverage 54.69% 54.70%
========================================
Files 582 582
Lines 78430 78293 -137
========================================
- Hits 42899 42829 -70
+ Misses 32319 32258 -61
+ Partials 3212 3206 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
<!-- please provide a detailed description of the changes made in this pull request. --> ## Description This PR improves the recently merged docs linter. It adds checks for improperly escaped JSX tags, and makes the addition of further linter checks easier with better pipelining. It also implements a change to the gnoclient docs by introducing godoc, as well as a few minor fixes. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [x] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Description
This PR improves the recently merged docs linter. It adds checks for improperly escaped JSX tags, and makes the addition of further linter checks easier with better pipelining.
It also implements a change to the gnoclient docs by introducing godoc, as well as a few minor fixes.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description