-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: align on-chain valset with genesis.json
valset
#2465
Conversation
This reverts commit 2be7527.
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
genesis.json
valset with on-chain valsetgenesis.json
valset
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2465 +/- ##
=======================================
Coverage 54.71% 54.71%
=======================================
Files 583 583
Lines 78499 78499
=======================================
+ Hits 42947 42953 +6
+ Misses 32344 32340 -4
+ Partials 3208 3206 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closing this PR after discussing with @moul a while back -- we are fine with genesis coordination being manual for now, and we will utilize other mechanisms for this sort of thing in the future |
Description
Depends on #2130
This PR introduces an alignment between the
genesis.json
validator set (lives on-disk), and the on-chain validator set in the genesis transactions.How it works:
genesis.json
valsetconfig.toml
), and it's none by default (current behavior). The reasoning behind keeping it in the node'sconfig.toml
is to ensure this value is accessible from different stages of the chain pipeline (fromgenesis.json
generation ->EndBlocker
)r/sys/vals
Realm (the deployment transaction must be present in thegenesis.json
) before starting their chaingenesis.json
, ther/sys/vals
Realm deployment transaction is updated to reflect the current state in thegenesis.json
init
(constructor) part of ther/sys/vals
Realm is updated, to reflect the changes. We use Go's templates for this purpose as it's a simple pastecc @gfanton @moul
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description