feat: improve r/gnoland/valopers implementation
#2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkovicmilos
added
the
don't merge
moul
reviewed
Jul 5, 2024
moul
reviewed
Jul 5, 2024
moul
reviewed
Jul 5, 2024
moul
reviewed
Jul 5, 2024
moul
reviewed
Jul 5, 2024
moul
reviewed
Jul 5, 2024
moul
reviewed
Jul 5, 2024
moul
reviewed
Jul 5, 2024
moul
requested changes
Jul 5, 2024
zivkovicmilos
removed
the
don't merge
moul
reviewed
Jul 5, 2024
moul
reviewed
Jul 5, 2024
moul
reviewed
Jul 5, 2024
moul
approved these changes
Jul 5, 2024
moul
reviewed
Jul 6, 2024
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
## Description This PR improves the gno implementation of the `valopers` Realm. Waiting on gnolang#2380 to add a context-based Govdao pattern before merging. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the gno implementation of the
valopersRealm.Waiting on #2380 to add a context-based Govdao pattern before merging.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description