Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): Enhance r/demo/grc20factory #2607

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

linhpn99
Copy link
Contributor

@linhpn99 linhpn99 commented Jul 20, 2024

  • Query the number of GRC20 instances created from this realm
  • Set new admin
  • Render a list of tokens and admins
  • Unit test for new functions
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@linhpn99 linhpn99 requested review from a team as code owners July 20, 2024 10:53
@linhpn99 linhpn99 requested review from mvertes and ltzmaxwell and removed request for a team July 20, 2024 10:53
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jul 20, 2024
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.21%. Comparing base (e5c1152) to head (3d879e4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2607   +/-   ##
=======================================
  Coverage   60.21%   60.21%           
=======================================
  Files         562      562           
  Lines       75038    75038           
=======================================
+ Hits        45184    45186    +2     
+ Misses      26479    26476    -3     
- Partials     3375     3376    +1     
Flag Coverage Δ
contribs/gnodev 61.40% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
gno.land 64.57% <ø> (ø)
gnovm 64.33% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (+0.35%) ⬆️
tm2 62.02% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant