Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): a shifumi (rock, paper, scissors) smart contract #2629

Merged
merged 7 commits into from
Aug 30, 2024

Conversation

mvertes
Copy link
Contributor

@mvertes mvertes commented Jul 25, 2024

A very simple game as a smart contract. It's possible to play against yourself, or another opponent. UI could be improved.

No provision against cheating, no gain or automatic action.

Related to #611.

Screenshot 2024-07-24 at 16 24 28
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • [*] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • [*] No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • [*] Added references to related issues and PRs
  • [*] Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

A very simple game as a smart contract. It's possible to play
against yourself, or another opponent. UI could be improved.

No provision against cheating, no gain or automatic action.

Related to gnolang#611.
@mvertes mvertes requested review from a team as code owners July 25, 2024 09:39
@mvertes mvertes requested review from jaekwon and ltzmaxwell and removed request for a team July 25, 2024 09:39
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.20%. Comparing base (e5c1152) to head (c0d3ac7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2629      +/-   ##
==========================================
- Coverage   60.21%   60.20%   -0.01%     
==========================================
  Files         562      562              
  Lines       75038    75038              
==========================================
- Hits        45184    45180       -4     
- Misses      26479    26480       +1     
- Partials     3375     3378       +3     
Flag Coverage Δ
contribs/gnodev 60.58% <ø> (-0.82%) ⬇️
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
gno.land 64.57% <ø> (ø)
gnovm 64.33% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (+0.35%) ⬆️
tm2 61.95% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few suggestions for good practices

examples/gno.land/r/demo/games/shifumi/shifumi.gno Outdated Show resolved Hide resolved
examples/gno.land/r/demo/games/shifumi/shifumi.gno Outdated Show resolved Hide resolved
examples/gno.land/r/demo/games/shifumi/shifumi.gno Outdated Show resolved Hide resolved
examples/gno.land/r/demo/games/shifumi/shifumi.gno Outdated Show resolved Hide resolved
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@mvertes mvertes merged commit 701ac17 into gnolang:master Aug 30, 2024
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants