-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: implement (Un)MarshalJSON(Amino) TypedValue #2652
Conversation
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2652 +/- ##
==========================================
- Coverage 60.12% 60.11% -0.01%
==========================================
Files 560 560
Lines 74690 74690
==========================================
- Hits 44905 44900 -5
+ Misses 26397 26396 -1
- Partials 3388 3394 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
After some discussion this PR is invalid, as it should better be implemented directly inside the gnovm. |
Work in Progress
This pull request aims to implement JSON marshaling on
TypedValue
. It includes:[]byte
data, for example.TypedValue
Current State:
objectid
Note: Don't be scared by the number of lines added. The most important parts of the code are located in
value_json.go
andvalue_json_test.go
, asencoding/json/*
is mostly taken fromprotojson
.TODO:
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description