-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove gno mod download
#2673
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2673 +/- ##
==========================================
- Coverage 60.11% 60.06% -0.06%
==========================================
Files 560 560
Lines 74918 74735 -183
==========================================
- Hits 45039 44887 -152
+ Misses 26504 26488 -16
+ Partials 3375 3360 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you. I tried this out a few weeks ago and was confused by its behavior. It would be nice to eventually have a working gno mod download
to better enable local development, but I think it's fine to remove it for now.
Please don't remove that - Playground needs this command to download realm dependencies for a language server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not remove it, but improve it.
@moul |
Closing this PR as I haven't gotten clarity on what would be an alternative to this buggy functionality |
Description
This PR removes the useless, and frankly wrong
gno mod download
, removing the recent CI headaches we've had with chain querying from tests.BREAKING CHANGE: absolutely useless command dropped
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description