fix: Pager added, improves p/demo/ui improvements #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🧾 package/realm
AliSinaDevelo
changed the title
AliSinaDevelo
changed the title
jefft0
added
the
review/triage-pending
|
Hello @AliSinaDevelo . This PR defines Pager functionality. How does this relate to the Pager defined in PR #2584 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corresponds to #903 p/demo/ui improvements, pager added with unit tests
pager type struct defined to hold the page user is corrently on, total number of pages, and the prefix for the url used go generate pages.
the methods append the page number to the PathPredix to get complete URL for each page link.
several unit tests added to ui_test.gno:
TestPagerSinglePage
TestPagerMultiplePages
TestPagerFirstPage
TestPagerLastPage