Dev/thox/millipede #2723
Closed
Dev/thox/millipede #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: deelawn <dboltz03@gmail.com>
Co-authored-by: deelawn <dboltz03@gmail.com>
Co-authored-by: deelawn <dboltz03@gmail.com>
Co-authored-by: deelawn <dboltz03@gmail.com>
Co-authored-by: deelawn <dboltz03@gmail.com>
- Correct admin role checks and assertions in TestSetRoleAdmin. - Fix error handling in TestAssertOrigCallerIsAdmin. - Ensure proper panic checks in TestRevokeRoleNonAdmin. - Improve role grant, revocation, and renunciation tests.
- Used PrevRealm to get the caller's address instead of OrigCaller. - Added CallerIsAdmin method to return an error if the caller is not admin. - Created AssertCallerIsAdmin method to panic if the caller is not admin. - Updated tests to reflect these changes. bash: line 1: :wq: command not found bash: line 1: wq: command not found
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2723 +/- ##
=======================================
Coverage 60.23% 60.24%
=======================================
Files 562 562
Lines 75091 75091
=======================================
+ Hits 45230 45237 +7
+ Misses 26481 26474 -7
Partials 3380 3380
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description