-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tm2): crypto.Address json Marshal #2756
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2756 +/- ##
==========================================
+ Coverage 60.24% 60.42% +0.18%
==========================================
Files 562 563 +1
Lines 75031 75513 +482
==========================================
+ Hits 45200 45631 +431
- Misses 26458 26492 +34
- Partials 3373 3390 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It looks good, but it would be better if there was a clear explanation of a specific use case. |
@ltzmaxwell I've update the Issue message for better understanding of the situation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible, let's go for it.
Currently, on any
sdk.Message
, when doing a json.Marshal, the result look like:Now it's returning
This is already done for amino Marshalling, it's not for json.