-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ghverify): emit event when user request verification #2778
feat(ghverify): emit event when user request verification #2778
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2778 +/- ##
==========================================
+ Coverage 63.08% 63.10% +0.02%
==========================================
Files 563 563
Lines 79254 79333 +79
==========================================
+ Hits 49998 50064 +66
- Misses 25896 25905 +9
- Partials 3360 3364 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is necessary. How does this event give more information to an off-chain user, if they could just use the indexer with this query?
query {
transactions(filter: {
message: {
route: vm,
type_url: add_package,
vm_param: {
exec: {
pkg_path: "gno.land/r/gnoland/ghverify",
func: "RequestVerification"
}
}
}
}) {
hash
messages {
value {
... on MsgCall {
args
}
}
}
gas_wanted
success
response {
error
}
}
}
We should always practice emitting events, even if we have an indexer. |
@thehowl if a realm (like a dao or an abstracted account) calls RequestVerification, it will be ignored by agents using your solution |
After the discussion in #2777, I'm OK with the event being emitted - but I still think we need to use queries as a way to get the source of truth, and use events only as a pub/sub mechanism. |
related to #2777
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description