fix(gonative): add constant information when we define a go native value

[omarsy]

First part of the fix: #2836

The second part is addressed here: #2731

[codecov]

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.97%. Comparing base (69400d4) to head (0671c88).
Report is 42 commits behind head on master.

Files with missing lines	Patch %	Lines
gnovm/pkg/gnolang/gonative.go	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2848      +/-   ##
==========================================
+ Coverage   60.90%   60.97%   +0.07%     
==========================================
  Files         564      564              
  Lines       75273    75279       +6     
==========================================
+ Hits        45844    45902      +58     
+ Misses      26057    26008      -49     
+ Partials     3372     3369       -3     

Flag	Coverage Δ
contribs/gnodev	61.46% <ø> (ø)
contribs/gnofaucet	14.46% <ø> (ø)
gno.land	67.92% <ø> (+0.75%)	⬆️
gnovm	65.78% <97.67%> (+<0.01%)	⬆️
misc/genstd	80.54% <ø> (ø)
misc/logos	20.23% <ø> (+0.35%)	⬆️
tm2	62.11% <ø> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thehowl]

I think all values declared using gonative should be not modifiable.

Can we just have that if you have an assignment on a value which is statically typed as a native value, you cannot change it?

[omarsy]

I think all values declared using gonative should be not modifiable.

Can we just have that if you have an assignment on a value which is statically typed as a native value, you cannot change it?

We have an example of editing a native value here: https://github.com/gnolang/gno/blob/master/gnovm/tests/files/assign0b_native.gno. I'm unsure if this is something we want to prohibit.

[thehowl]

The fact that values are modifiable makes functions modifiable, too:

package main

import (
	"fmt"
)

func main() {
	fmt.Sprintf = func(v string, p ...interface{}) string { return "123" }
	println(fmt.Sprintf("a", "b"))
}

// Output:
// 123

Seeing as we eventually want to remove gonative (#1361), I think it's sensible to remove the ability to modify these entirely.

[omarsy]

Yes maybe we should forbid the edit only for functions and constants. WDYT ?

[thehowl]

Whatever is simplest.

[omarsy]

Added here: 0671c88

Nice catch for the issue ^^