chore: tidy misc/loop mod
#3065
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3065 +/- ##
==========================================
- Coverage 63.33% 63.33% -0.01%
==========================================
Files 548 548
Lines 78599 78601 +2
==========================================
- Hits 49784 49783 -1
- Misses 25461 25462 +1
- Partials 3354 3356 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
before merging this PR, let's fix the CI so that it detects the issue. ideally, fix the CI in this PR :) |
sw360cab
approved these changes
Nov 5, 2024
zivkovicmilos
commented
Nov 5, 2024
| @@ -53,6 +53,8 @@ func ReadGenesisTxs(ctx context.Context, path string) ([]TxWithMetadata, error) | |||
| scanner = bufio.NewScanner(file) | |||
| ) | |||
|
|
|||
| scanner.Buffer(make([]byte, 1_000_000), 2_000_000) | |||
There was a problem hiding this comment.
For context on this -- the default scanner limit is ~65k chars, which proved to be too little for even our portal loop transactions, so I bumped the value to ~1M chars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tidies the
misc/loopgo.mod. I'm not sure how the CI didn't catch this, or why it's green 🤷♂️It also fixes the failing CI, but downgrading
gnomigrateto1.22- fun :)Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description