Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GovDAO implementation proposal. #3389

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ajnavarro
Copy link
Contributor

@ajnavarro ajnavarro commented Dec 20, 2024

Sharing the work I'm doing implementing GovDAO from Jae's docs:

https://gist.github.com/jaekwon/918ad325c4c8f7fb5d6e022e33cb7eb3

Still, some things are missing, but we can start discussing and tweaking them on top of the actual code.

Main concepts

  • Proposal: This struct gives some extra metadata about the proposal and also includes an Executor that will be in charge to run the proposal when accepted.
  • Executor: It contains a function and some specific metadata needed to run the provided function. It is in charge of running that code when the proposal is accepted. You can see some private callback functions used by the executor on callbacks.gno file. All of these callback functions are private because they are only intended to be executed through proposals created inside the dao (govdao.gno public functions).
  • Law: It defines all the business logic. It is done that way to make it possible to create proposals to change the actual Law if needed.
  • Members: Users that, depending on the Tier they are, have different characteristics and power for voting Proposals.

Screenshots

screenshot-127 0 0 1_8888-2025 01 09-17_08_38

screenshot-127 0 0 1_8888-2025 01 09-17_17_48

TODO

  • Remove and implement all TODOs in the code
  • Invitation points functionality missing
  • Discuss some ideas about how to implement/force at code level Tier sices requirements.
  • Add more tests
  • Check with @n2p5 some ideas about how we can use govDAO to propose changes to the constitution
  • Old proposals pagination
  • Implement all logic for withdrawal
  • Add gno doc to types

Don't hesitate to ping me if more context/info is needed.

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Dec 20, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 20, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: ajnavarro/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@ajnavarro ajnavarro changed the title feature: GovDAO implementation proposal. feat: GovDAO implementation proposal. Dec 20, 2024
It follows specs from https://gist.github.com/jaekwon/918ad325c4c8f7fb5d6e022e33cb7eb3

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@Kouteki Kouteki added the in focus Core team is prioritizing this work label Dec 20, 2024
@ajnavarro ajnavarro marked this pull request as draft December 20, 2024 15:31
@Kouteki Kouteki added this to the 🚀 Mainnet beta launch milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in focus Core team is prioritizing this work 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants