Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/gno): pkgaddr sub-command #3416

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

n0izn0iz
Copy link
Contributor

@n0izn0iz n0izn0iz commented Dec 28, 2024

Adds a gno sub-command called pkgaddr that takes a string as argument and outputs the corresponding package address using `gnolang.DerivePkgAddr'

Example usage:

> gno pkgaddr gno.land/r/demo/users
g17m4ga9t9dxn8uf06p3cahdavzfexe33ecg8v2s

Signed-off-by: Norman <norman@samourai.coop>
@n0izn0iz n0izn0iz changed the title feat(cmd/gno): pkgaddr subcommand feat(cmd/gno): pkgaddr sub-command Dec 28, 2024
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Dec 28, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 28, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: n0izn0iz/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Signed-off-by: Norman <norman@samourai.coop>
Signed-off-by: Norman <norman@samourai.coop>
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should find a better way to manage the "not go related subcommands." This could involve creating a dedicated subcommand category for these helpers, using a prefix, or simply placing everything in contribs/.

I suggest starting with contribs/. It could be in gnodev if we believe there's a daily need for it (I don't think there is, cc @gfanton), or we could create a new tool. A contribs/gnoconv generic binary for such operations might make sense and could pave the way for other similar helpers until we find a way to integrate these usages more effectively (or not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

3 participants