Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faucet update #371

Closed
wants to merge 1 commit into from
Closed

faucet update #371

wants to merge 1 commit into from

Conversation

r3v4s
Copy link
Contributor

@r3v4s r3v4s commented Oct 25, 2022

#364
#361

  • divided faucet realm into two different realms to specific each realms's role (admin & controller)
  • add more clear faucet rules

https://discord.com/channels/957002220384182312/957685423696646155/1028089477664624670

  • support multiple controller address // b1t working on it
  • discord bot // b1t working on it

}


var reqAddr = make(map[std.Address]uint)
Copy link
Contributor

@anarcher anarcher Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Realm, we can not use map type in package level for now. Consider to use p/avl/MutTree :-)

@moul
Copy link
Member

moul commented Oct 25, 2022

@r3v4-onbloc thank you for this PR

What are you trying to address with that split? We may update the existing faucet code to eventually support a slide of controllers instead of just one unique controller, but I don’t think we should split the faucet code.

To be open, I used to develop it into two separate contracts and fallback to something more simple, which is the current unique contract.

@moul
Copy link
Member

moul commented Oct 25, 2022

Also, note that we'll launch test3 in the next few days. We'll keep the current faucet but will make sure that r/faucet is also there so we can develop the discord bot a few days after the launch in case the existing faucet is drained by scripters again.

So let's focus on making necessary changes in the current realm in preparation for the upcoming discord bot.

@moul moul added this to the 🏗3️⃣ test3.gno.land milestone Oct 25, 2022
@r3v4s
Copy link
Contributor Author

r3v4s commented Oct 25, 2022

Bonjour @moul

With splitting faucet contract, I wanted to address High Cohesion, Low Coupling
Perhaps we could address it using different gno files in same package, not (entirely) different package

As you know, b1t is working on single faucet and discord bot calling it which should be done shortly.

After b1t finishes job, maybe we can make r/faucet work better(more faucet rules, more inner function to execute and etc.)

If you don't mind I'll leave PR open draft and close(or request merge) later when test3 launches and faucet with bot works properly as we want.

@r3v4s r3v4s closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants