Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updates for the faucet community bot #400

Merged
merged 11 commits into from
Mar 12, 2023
Merged

chore: updates for the faucet community bot #400

merged 11 commits into from
Mar 12, 2023

Conversation

piux2
Copy link
Contributor

@piux2 piux2 commented Nov 27, 2022

The code is to complete the example. We do not need to load it when starting gnoland. We will deploy the contract separately since it requires a large amount of deposit to fund the faucet when deploying the contract.

The deployment script is in https://github.com/gnolang/community-faucet-bot

#372

#362
#364

@piux2 piux2 changed the title updated package location and number of controllers. Faucet Contract for community bot: updated package location and number of controllers. Nov 27, 2022
zivkovicmilos
zivkovicmilos approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, as always.
Looks good to me 💯

Please resync this master branch with the current repo master 🙏

examples/gno.land/r/gnoland/faucet/admin.gno Show resolved Hide resolved
examples/gno.land/r/gnoland/faucet/admin.gno Show resolved Hide resolved
examples/gno.land/r/gnoland/faucet/admin.gno Show resolved Hide resolved
examples/gno.land/r/gnoland/faucet/admin.gno Show resolved Hide resolved
examples/gno.land/r/gnoland/faucet/faucet.gno Show resolved Hide resolved
examples/gno.land/r/gnoland/faucet/admin.gno Show resolved Hide resolved
harry-hov
harry-hov reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@harry-hov harry-hov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw lots of unwanted newline which can be removed.

@moul moul mentioned this pull request Jan 11, 2023
Open
@moul moul added this to the 📆 Game-Of-Realms milestone Jan 19, 2023
@moul moul requested a review from a team as a code owner January 19, 2023 18:28
moul
moul requested changes Jan 19, 2023
View reviewed changes
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I think the PR is great now. It just need to be updated with recent changes on master (p/demo/avl updates).

Then we can merge 👍

@piux2 piux2 requested a review from moul January 20, 2023 21:36
@piux2
Copy link
Contributor Author

piux2 commented Feb 18, 2023

Hey, I think the PR is great now. It just need to be updated with recent changes on master (p/demo/avl updates).

Then we can merge 👍

@moul can you review this? I made the changes required last month. thanks

@moul moul changed the title Faucet Contract for community bot: updated package location and number of controllers. chore: updates for the faucet community bot Mar 12, 2023
@moul moul merged commit bd598a5 into gnolang:master Mar 12, 2023
@thehowl thehowl mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harry-hov harry-hov harry-hov left review comments

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@moul moul moul approved these changes

Assignees

@piux2 piux2

Labels
None yet
Projects
🚀 The Launch [DEPRECATED]
Archived in project
Milestone
🚀 Mainnet launch
Development

Successfully merging this pull request may close these issues.
4 participants
@piux2 @moul @zivkovicmilos @harry-hov