Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump linter version to v1.51 #536

Merged
merged 5 commits into from
Feb 28, 2023
Merged

chore: bump linter version to v1.51 #536

merged 5 commits into from
Feb 28, 2023

Conversation

zivkovicmilos
Copy link
Member

@zivkovicmilos zivkovicmilos commented Feb 23, 2023 •
edited
Loading

Description

Since the minimum go version has been bumped to 1.19 in #518, we can also bump the linter version to 1.51

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist (for contributors)

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Manually ran the latest version of golangci-lint (golangci-lint has version 1.51.2 built from 3e8facb on 2023-02-19T20:54:52Z)

@zivkovicmilos zivkovicmilos added the 🐞 bug Something isn't working label Feb 23, 2023
@zivkovicmilos zivkovicmilos requested a review from a team as a code owner February 23, 2023 12:45
@zivkovicmilos zivkovicmilos self-assigned this Feb 23, 2023
@zivkovicmilos zivkovicmilos changed the title Bump linter version to latest chore: bump linter version to latest Feb 23, 2023
moul
moul reviewed Feb 26, 2023
View reviewed changes
.github/workflows/lint.yml Outdated Show resolved Hide resolved
@zivkovicmilos zivkovicmilos changed the title chore: bump linter version to latest chore: bump linter version to v1.51 Feb 27, 2023
@zivkovicmilos zivkovicmilos mentioned this pull request Feb 28, 2023
Merged
11 tasks
@moul moul merged commit 85a9485 into gnolang:master Feb 28, 2023
@zivkovicmilos zivkovicmilos deleted the feature/bump-linter-version branch March 1, 2023 11:23
harry-hov pushed a commit to harry-hov/gno that referenced this pull request Mar 6, 2023
@zivkovicmilos @harry-hov
chore: bump linter version to v1.51 (gnolang#536)
17b7b2b
@moul moul added this to the 💡Someday/Maybe milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehowl thehowl thehowl approved these changes

@moul moul moul approved these changes

Assignees

@zivkovicmilos zivkovicmilos

Labels
🐞 bug Something isn't working
Projects
🚀 The Launch [DEPRECATED]
Archived in project
Milestone
💡Someday/Maybe
Development

Successfully merging this pull request may close these issues.
3 participants
@zivkovicmilos @moul @thehowl