-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace old realm path to current one #681
fix: replace old realm path to current one #681
Conversation
I can be wrong but I think it's the inverse actually, |
Yes you're right, did I mis guide something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unit tests are probably outdated
Exactly, the PR seems to me to be right though. @r3v4s Do you want to finish this and update the unit tests? No problem if you don't, I'll close this and make another PR |
@thehowl I'll finish it :D |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #681 +/- ##
==========================================
- Coverage 48.44% 46.73% -1.72%
==========================================
Files 409 492 +83
Lines 61965 69614 +7649
==========================================
+ Hits 30019 32533 +2514
- Misses 29446 34366 +4920
- Partials 2500 2715 +215 ☔ View full report in Codecov by Sentry. |
Hey @r3v4s, what's the status on this? |
oops, sorry. forgot to make it ready for review after ci successful |
Description
Function was using old user realm path which doesn't have 'demo' string in path.
Additional
There are bunch of test files(
z_*_filetest.gno
) with old realm path, should I update all of it?