Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace old realm path to current one #681

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

r3v4s
Copy link
Contributor

@r3v4s r3v4s commented Mar 31, 2023

Description

Function was using old user realm path which doesn't have 'demo' string in path.

Additional

There are bunch of test files(z_*_filetest.gno) with old realm path, should I update all of it?

@r3v4s r3v4s requested a review from a team as a code owner March 31, 2023 02:37
@r3v4s r3v4s changed the title fix: wrong user realm path fix: old user realm path Mar 31, 2023
@tbruyelle
Copy link
Contributor

I can be wrong but I think it's the inverse actually, r/users is the old one, and r/demo/users is the current one.

@r3v4s
Copy link
Contributor Author

r3v4s commented Mar 31, 2023

I can be wrong but I think it's the inverse actually, r/users is the old one, and r/demo/users is the current one.

Yes you're right, did I mis guide something?

Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests are probably outdated

@thehowl
Copy link
Member

thehowl commented Jul 6, 2023

I can be wrong but I think it's the inverse actually, r/users is the old one, and r/demo/users is the current one.

Exactly, the PR seems to me to be right though.

@r3v4s Do you want to finish this and update the unit tests? No problem if you don't, I'll close this and make another PR

@moul moul changed the title fix: old user realm path chore: fix old user realm path Jul 6, 2023
@r3v4s
Copy link
Contributor Author

r3v4s commented Jul 13, 2023

@thehowl I'll finish it :D

@r3v4s r3v4s marked this pull request as draft July 13, 2023 01:42
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 8, 2023
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels May 7, 2024
@r3v4s r3v4s requested a review from leohhhn May 7, 2024 04:12
@r3v4s r3v4s changed the title chore: fix old user realm path fix: replace old realm path to current one May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.73%. Comparing base (dd68d61) to head (c1bbc15).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
- Coverage   48.44%   46.73%   -1.72%     
==========================================
  Files         409      492      +83     
  Lines       61965    69614    +7649     
==========================================
+ Hits        30019    32533    +2514     
- Misses      29446    34366    +4920     
- Partials     2500     2715     +215     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leohhhn
Copy link
Contributor

leohhhn commented May 7, 2024

Hey @r3v4s, what's the status on this?

@r3v4s r3v4s marked this pull request as ready for review May 7, 2024 07:48
@r3v4s r3v4s requested review from thehowl and a team as code owners May 7, 2024 07:48
@r3v4s
Copy link
Contributor Author

r3v4s commented May 7, 2024

Hey @r3v4s, what's the status on this?

oops, sorry. forgot to make it ready for review after ci successful

@zivkovicmilos zivkovicmilos merged commit 25aabf9 into gnolang:master Jun 10, 2024
15 of 17 checks passed
@zivkovicmilos zivkovicmilos deleted the fix/realm-path-typo branch June 10, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: 🌟 Wanted for Launch
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants