Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gnovm): PrevRealm in _test files #896

Merged
merged 17 commits into from
Aug 6, 2023
Merged

fix(gnovm): PrevRealm in _test files #896

merged 17 commits into from
Aug 6, 2023

Commits on Jul 31, 2023

  1. fix(gnovm): PrevRealm in _test files 

    When _test files are executed, the pkg path is set to the real path to
the test, which starts by `./examples/gno.land`, this leads to
interpreting the test package as a non-realm, because a realm must
start with `gno.lang/r`.

Because of that, when calling `PrevRealm`, a test package is never
considered as a realm whereas sometime it should.

The fix truncates the `./examples` prefix from the test package, which
ensures it is well detected as a realm when required.

This had several consequences on tests execution, like `testing` and the
test template must not declare global variable, or else the VM tries to
persist them at the end of transaction and that triggers error.
    @tbruyelle
    tbruyelle committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    9f5a5ae View commit details
    Browse the repository at this point in the history

  2. fix for TestFunctions that write the store 

    Probably dumb fix, should be improved
    @tbruyelle
    tbruyelle committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    5667f86 View commit details
    Browse the repository at this point in the history

  3. fix annoying test

    @tbruyelle
    tbruyelle committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    24fa1d3 View commit details
    Browse the repository at this point in the history

  4. simplify

    @tbruyelle
    tbruyelle committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    ea64d71 View commit details
    Browse the repository at this point in the history

  5. replace _test filter with change in tests functions

    @tbruyelle
    tbruyelle committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    f910bf0 View commit details
    Browse the repository at this point in the history

  6. remove rename 

    not so well and add too much diff
    @tbruyelle
    tbruyelle committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    2f3f30f View commit details
    Browse the repository at this point in the history

  7. better use the machine API

    @tbruyelle
    tbruyelle committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    47fbd41 View commit details
    Browse the repository at this point in the history

  8. do not assign id to testmain if it's not a realm

    @tbruyelle
    tbruyelle committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    917337b View commit details
    Browse the repository at this point in the history

  9. remove global var from testing

    @tbruyelle
    tbruyelle committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    cd3213d View commit details
    Browse the repository at this point in the history

  10. Revert "replace _test filter with change in tests functions" 

    This reverts commit 763ac29.
    @tbruyelle
    tbruyelle committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    a3e86bd View commit details
    Browse the repository at this point in the history

  11. exclude testing from saved objects

    @tbruyelle
    tbruyelle committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    85cc135 View commit details
    Browse the repository at this point in the history

  12. rename pkgName to gnoPkgPath

    @tbruyelle
    tbruyelle committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    a8ab7e9 View commit details
    Browse the repository at this point in the history

  13. read gnoPkgPath from gno.mod, if not found, generate a random realm one

    @tbruyelle
    tbruyelle committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    13089a5 View commit details
    Browse the repository at this point in the history

  14. add comment

    @tbruyelle
    tbruyelle committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    7798dfb View commit details
    Browse the repository at this point in the history

  15. more splitRegexp outside the loop

    @tbruyelle
    tbruyelle committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    836b71d View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Update gnovm/pkg/gnomod/parse.go 

    Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
    @tbruyelle @moul
    tbruyelle and moul committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    724d3b7 View commit details
    Browse the repository at this point in the history

  2. fix after apply suggestion

    @tbruyelle
    tbruyelle committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    0404c36 View commit details
    Browse the repository at this point in the history