Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deployments): enable empty blocks creation on staging #899

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

moul
Copy link
Member

@moul moul commented Jun 15, 2023

Addresses #863
Related with gnolang/hackerspace#9

Contributors Checklist

  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

Maintainers Checklist

  • Checked that the author followed the guidelines in CONTRIBUTING.md
  • Checked the conventional-commit (especially PR title and verb, presence of BREAKING CHANGE: in the body)
  • Ensured that this PR is not a significant change or confirmed that the review/consideration process was appropriate for the change

@moul moul requested a review from a team as a code owner June 15, 2023 07:34
@dongwon8247
Copy link
Member

@moul When do you think this will be merged? in the current testnet3? or testnet4?

@r3v4s
Copy link
Contributor

r3v4s commented Jun 15, 2023

@moul seems to be creating empty block is false by default

cfg := config.LoadOrMakeConfigWithOptions(rootDir, func(cfg *config.Config) {
cfg.Consensus.CreateEmptyBlocks = false
cfg.Consensus.CreateEmptyBlocksInterval = 60 * time.Second

But when running local node, it does create empty block every 60 seconds.
Shouldn't it be happen when above setting is set to true, not false?

or did I understood something wrong?

UPDATE

just saw this.
#863 (comment)

@moul moul changed the title chore(deployments): enable empty blocks création on staging chore(deployments): enable empty blocks creation on staging Jun 16, 2023
@moul
Copy link
Member Author

moul commented Jun 16, 2023

@moul When do you think this will be merged? in the current testnet3? or testnet4?

This is a first try on staging (reset every hour). If everything goes smoothly, I think we can enable it on test3 and then keep it for the next versions.

@moul moul merged commit b6dc190 into master Jun 16, 2023
@moul moul deleted the moul-patch-1 branch June 16, 2023 10:55
Doozers pushed a commit to Doozers/gno that referenced this pull request Aug 31, 2023
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants