Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update labels.json #995

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

chore: update labels.json #995

wants to merge 2 commits into from

Conversation

moul
Copy link
Member

@moul moul commented Jul 27, 2023

Based on https://github.com/golang/go/labels?page=2&sort=name-asc

Depends on gnolang/gh-labels#127

Need help for colors.

Checklists...

Contributors Checklist

  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Addresses gnolang/meetings#18

@moul moul requested a review from a team as a code owner July 27, 2023 20:20
@moul moul self-assigned this Jul 27, 2023
@moul moul requested a review from zivkovicmilos July 27, 2023 20:20
@moul
Copy link
Member Author

moul commented Jul 27, 2023

@zivkovicmilos what will happen once merged, because I see that we’ve some labels that are not defined by this file, i.e., labels used by the labeler.yml.

@zivkovicmilos
Copy link
Member

zivkovicmilos commented Jul 28, 2023

@moul
Actually nothing will happen, unless we run the GitHub label-er tool on the repo (currently private).
It's not dynamic in a sense that it triggers GitHub labels to change, the tool needs to be manually run using the labels.json file

@moul
Copy link
Member Author

moul commented Jul 28, 2023

OK, and do you think that running it can actually delete labels from labeler.yml?

Would you mind reviewing my PR and running the script yourself?

@zivkovicmilos
Copy link
Member

OK, and do you think that running it can actually delete labels from labeler.yml?

Would you mind reviewing my PR and running the script yourself?

I just checked the labels we have in the labels.json and the labels we have defined in the repo.
I can confirm that running the label tool with this json file will delete labels that are not defined in the labels.json, but are defined in the repo. To avoid this, we just need to make sure the labels.json contains all up-to-date labels we added manually since last running the tool.

The tool assumes that the labels.json is the source of truth, so in reality we should only be updating this file, and run the tool afterwards

Do you want me to push to this branch the changes that are needed to make sure we preserve everything?
You'd need to run the tool yourself after those changes, because I don't have repo modification permissions

@moul
Copy link
Member Author

moul commented Aug 3, 2023

Can we update the tool so it can also fetch the current list, so we can fetch the list, make changes and then publish; otherwise we need to manually review the difference and expect no typo/utf-8 issues.

Then, once the tool support fetching, we can run it and update some guidelines to make it the new way of managing labels in the future.


Edit: I've tasked @gnolang/devrels with delving deeper into this matter, encompassing both the current situation and the wider context. The objective is to establish a cohesive strategy for label management. Perhaps centralizing the process through an organization-wide repository, as opposed to individual .github/ folders, might be more effective. Additionally, we should ensure that any new labels introduced by someone or an automated process are preserved and not inadvertently removed.

@moul moul marked this pull request as draft August 3, 2023 17:51
@moul moul assigned waymobetta and unassigned moul Aug 13, 2023
@moul moul added this to the 💡Someday/Maybe milestone Sep 6, 2023
@moul
Copy link
Member Author

moul commented Oct 25, 2023

Assigning this to @gnolang/devrels for follow-up.
Please, be careful not to delete labels to avoid manual relabeling of issues.
I highly recommend working on a fork before making these changes.
Thank you.

@moul moul requested a review from a team October 25, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Status: 🙏🏻 To Delegate
Status: 🔵 Not Needed for Launch
Development

Successfully merging this pull request may close these issues.

3 participants