Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tx-archive std format #10

Closed
wants to merge 6 commits into from

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Jan 31, 2024

Description

This PR changes the exporter internals to handle the new, standard format of transaction data, instead of the legacy one from tx-archive. Legacy support will be added later, as it is not a priority.

@leohhhn leohhhn self-assigned this Jan 31, 2024
@leohhhn leohhhn marked this pull request as ready for review January 31, 2024 08:29
extractor/main.go Outdated Show resolved Hide resolved
extractor/types.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would prefer another review just to be sure that everything is ok.

@leohhhn
Copy link
Contributor Author

leohhhn commented Feb 1, 2024

Moving this PR because it seems I branched it off wrong, and I can't seem to fix it. Here is the clean PR: #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants