Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin codegen and check it on CI #55

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

n0izn0iz
Copy link
Contributor

@n0izn0iz n0izn0iz commented Jun 11, 2024

This pins the 99designs/gqlgen version and check that there if no diff after make generate on CI

There is a big removal in models_gen.go but I think this is probably a desynced codegen since no tests breaks and the cmd builds/runs correctly, this PR aims to avoid these situations.

Signed-off-by: Norman Meier <norman@samourai.coop>
@n0izn0iz n0izn0iz requested a review from a team as a code owner June 11, 2024 01:16
Signed-off-by: Norman Meier <norman@samourai.coop>
Signed-off-by: Norman Meier <norman@samourai.coop>
@n0izn0iz n0izn0iz changed the title feat: pin codegen and check it on CI chore: pin codegen and check it on CI Jun 11, 2024
Signed-off-by: Norman Meier <norman@samourai.coop>
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the addition 🙏

serve/graph/resolver.go Show resolved Hide resolved
n0izn0iz and others added 2 commits June 17, 2024 18:22
Signed-off-by: Norman Meier <norman@samourai.coop>
@zivkovicmilos zivkovicmilos merged commit 47387c2 into gnolang:main Jun 18, 2024
4 checks passed
@n0izn0iz n0izn0iz deleted the pin-codegen branch June 18, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants